ajantha-bhat commented on a change in pull request #4035:
URL: https://github.com/apache/carbondata/pull/4035#discussion_r535042468



##########
File path: 
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java
##########
@@ -1039,17 +1039,19 @@ private static void 
writeLoadMetadata(AbsoluteTableIdentifier identifier,
     }
   }
 
-  private static ReturnTuple isUpdateRequired(boolean isForceDeletion, 
CarbonTable carbonTable,
-      AbsoluteTableIdentifier absoluteTableIdentifier, LoadMetadataDetails[] 
details) {
+  private static ReturnTuple isUpdateRequired(boolean cleanStaleInProgress, 
boolean

Review comment:
       @vikramahuja1001 : please update the document of clean files.
   
   > 1 ) default clean files behaviour(clean files on table t1): clean MFD and 
Compacted segments will depend on query timeout(1 hr) and 
trashRetentionTimeout(7 days, default). 
   2) clean files on table t1 options('force'='true'): clean MFD and Compacted 
segments immediately(Do not check for any timeout)
   3) clean files on table t1 options('clean_inprgress'='true') : clean stale 
inprogress segments depends on trashRetentionTimeout, after 7 days(default 
behaviour)
   4) clean files on table t1 options('clean_inprgress'='true', 'force'='true') 
: clean MFD, Compacted and stale inprogress segments immediately.(Do not check 
for any timeout)
   
   **my comments for description** 
   1) you have not mentioned about trash in any of this. mention what happens 
to trash in each. 
   2)  And in your point 3) we should delete the expired MFD, compacted and 
expired trash folders also.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to