vikramahuja1001 commented on a change in pull request #4047:
URL: https://github.com/apache/carbondata/pull/4047#discussion_r539988131



##########
File path: core/src/main/java/org/apache/carbondata/core/index/IndexUtil.java
##########
@@ -290,6 +291,9 @@ private static FileInputFormat createIndexJob(CarbonTable 
carbonTable,
       Boolean isFallbackJob, List<String> segmentsToBeRefreshed, boolean 
isCountJob,
       Configuration configuration) {
     List<String> invalidSegmentNo = new ArrayList<>();

Review comment:
       This is not the only place where we call IndexJobs from, please check it 
in all the places and add there. Also check it in the case of prepriming too, 
you can ignore it if it's a non carbon segment.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to