[GitHub] [carbondata] nihal0107 commented on a change in pull request #4042: [CARBONDATA-4069] [CARBONDATA-4068] handled set streaming and long string for SI table or table having SI.

[GitBox]

nihal0107 commented on a change in pull request #4042:
URL: https://github.com/apache/carbondata/pull/4042#discussion_r540031235



##########
File path: 
integration/spark/src/main/scala/org/apache/spark/util/AlterTableUtil.scala
##########
@@ -916,6 +930,19 @@ object AlterTableUtil {
         }
       }
     }
+    // should not be present in index tables
+    val indexTables = CarbonIndexUtil.getSecondaryIndexes(carbonTable)

Review comment:
       done

##########
File path: 
integration/spark/src/main/scala/org/apache/spark/util/AlterTableUtil.scala
##########
@@ -916,6 +930,19 @@ object AlterTableUtil {
         }
       }
     }
+    // should not be present in index tables
+    val indexTables = CarbonIndexUtil.getSecondaryIndexes(carbonTable)
+    if (!indexTables.isEmpty) {
+      indexTables.asScala.map(indexTable => {
+        CarbonEnv.getCarbonTable(Some(carbonTable.getDatabaseName), 
indexTable)(sparkSession)
+          .getCreateOrderColumn.asScala.map(column => {
+          if (longStringCols.contains(column.getColName)) {
+            throw new MalformedCarbonCommandException(s"col 
${column.getColName} is " +

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org