[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4034: [CARBONDATA-4091] support prestosql 333 integartion with carbon

[GitBox]

ajantha-bhat commented on a change in pull request #4034:
URL: https://github.com/apache/carbondata/pull/4034#discussion_r553976013



##########
File path: 
integration/presto/src/main/prestosql/org/apache/carbondata/presto/CarbondataPageSourceProvider.java
##########
@@ -58,37 +60,40 @@
   private HdfsEnvironment hdfsEnvironment;
 
   @Inject public CarbondataPageSourceProvider(
+      TypeManager typeManager,
       HiveConfig hiveConfig,
       HdfsEnvironment hdfsEnvironment,
-      Set<HiveRecordCursorProvider> cursorProviders,
       Set<HivePageSourceFactory> pageSourceFactories,
-      TypeManager typeManager,
+      Set<HiveRecordCursorProvider> cursorProviders,
+      GenericHiveRecordCursorProvider genericCursorProvider,
       CarbonTableReader carbonTableReader) {
-    super(hiveConfig, hdfsEnvironment, cursorProviders, pageSourceFactories, 
typeManager);
+    super(typeManager, hiveConfig, hdfsEnvironment, pageSourceFactories, 
cursorProviders,
+        genericCursorProvider);
     this.carbonTableReader = requireNonNull(carbonTableReader, 
"carbonTableReader is null");
     this.hdfsEnvironment = hdfsEnvironment;
   }
 
   @Override
-  public ConnectorPageSource createPageSource(ConnectorTransactionHandle 
transactionHandle,
+  public ConnectorPageSource createPageSource(ConnectorTransactionHandle 
transaction,
       ConnectorSession session, ConnectorSplit split, ConnectorTableHandle 
table,
-      List<ColumnHandle> columns) {
-    HiveSplit carbonSplit =
-        checkType(split, HiveSplit.class, "split is not class HiveSplit");
+      List<ColumnHandle> columns, TupleDomain<ColumnHandle> dynamicFilter) {
+    HiveSplit carbonSplit = checkType(split, HiveSplit.class, "split is not 
class HiveSplit");
     this.queryId = carbonSplit.getSchema().getProperty("queryId");
     if (this.queryId == null) {
       // Fall back to hive pagesource.
-      return super.createPageSource(transactionHandle, session, split, table, 
columns);
+      return super.createPageSource(transaction, session, split, table, 
columns, dynamicFilter);
     }
+    // TODO: check and use dynamicFilter in CarbondataPageSource

Review comment:
       https://issues.apache.org/jira/browse/CARBONDATA-4103




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org