VenuReddy2103 commented on a change in pull request #4071:
URL: https://github.com/apache/carbondata/pull/4071#discussion_r566094958
##########
File path:
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/allqueries/TestQueryWithColumnMetCacheAndCacheLevelProperty.scala
##########
@@ -363,5 +365,20 @@ class TestQueryWithColumnMetCacheAndCacheLevelProperty
sql("CREATE INDEX parallel_index on parallel_index_load(b) AS
'carbondata'")
checkAnswer(sql("select b from parallel_index"), Seq(Row("bb"), Row("dd"),
Row("ff")))
sql("drop index if exists parallel_index on parallel_index_load")
+ val mock = mockIsSchemaModified()
+ sql("CREATE INDEX parallel_index on parallel_index_load(b) AS
'carbondata'")
+ checkAnswer(sql("select b from parallel_index"), Seq(Row("bb"), Row("dd"),
Row("ff")))
+ sql("drop index if exists parallel_index on parallel_index_load")
+ mock.tearDown()
+ }
+
+ def mockIsSchemaModified(): MockUp[TableInfo] = {
Review comment:
This tableInfo mockup instance for mocking isSchemaModified method to
return true is specific to a particular testcase. No need to define a separate
method. How about directly setup in testcase(line 368 can have like below) ? I
think, we can do same at other places also.
new MockUp[TableInfo] {
@Mock
def isSchemaModified(): Boolean = {
true
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
