ShreelekhyaG commented on a change in pull request #4104:
URL: https://github.com/apache/carbondata/pull/4104#discussion_r597428016
##########
File path:
processing/src/main/java/org/apache/carbondata/processing/merger/CompactionResultSortProcessor.java
##########
@@ -190,7 +200,7 @@ public boolean execute(List<RawResultIterator>
unsortedResultIteratorList,
LOGGER.error(e.getLocalizedMessage(), e);
throw e;
} finally {
- if (partitionSpec != null) {
Review comment:
Instead of passing boolean value, cant we directly get
`CarbonCommonConstants.CARBON_MERGE_INDEX_IN_SEGMENT `from properties? and the
if check should be - if merge index not enabled, then write segment file. As
below,
``` boolean isMergeIndexEnable =
Boolean.parseBoolean(CarbonProperties.getInstance().getProperty(
CarbonCommonConstants.CARBON_MERGE_INDEX_IN_SEGMENT,
CarbonCommonConstants.CARBON_MERGE_INDEX_IN_SEGMENT_DEFAULT));
if (partitionSpec != null && !isMergeIndexEnable) { ```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
