[ https://issues.apache.org/jira/browse/CARBONDATA-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574309#comment-15574309 ]
ASF GitHub Bot commented on CARBONDATA-297: ------------------------------------------- Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/229#discussion_r83354325 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/AbstractDataLoadProcessorStep.java --- @@ -55,14 +54,14 @@ public AbstractDataLoadProcessorStep(CarbonDataLoadConfiguration configuration, public abstract void intialize() throws CarbonDataLoadingException; /** - * Tranform the data as per the implemetation. + * Tranform the data as per the implementation. * * @return Array of Iterator with data. It can be processed parallel if implementation class wants * @throws CarbonDataLoadingException */ - public Iterator<Object[]>[] execute() throws CarbonDataLoadingException { - Iterator<Object[]>[] childIters = child.execute(); - Iterator<Object[]>[] iterators = new Iterator[childIters.length]; + public Iterator<CarbonRow>[] execute() throws CarbonDataLoadingException { + Iterator<CarbonRow>[] childIters = child.execute(); + Iterator<CarbonRow>[] iterators = new Iterator[childIters.length]; --- End diff -- In order to support batch conversion, it is better to put `Iterator<CarbonRow[]>[]` instead > 2. Add interfaces for data loading. > ----------------------------------- > > Key: CARBONDATA-297 > URL: https://issues.apache.org/jira/browse/CARBONDATA-297 > Project: CarbonData > Issue Type: Sub-task > Reporter: Ravindra Pesala > Assignee: Ravindra Pesala > Fix For: 0.2.0-incubating > > > Add the major interface classes for data loading so that the following jiras > can use this interfaces to implement it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)