Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/362#discussion_r90031584
  
    --- Diff: 
integration/spark/src/main/scala/org/apache/spark/sql/CarbonContext.scala ---
    @@ -208,4 +208,36 @@ object CarbonContext {
         }
     
       }
    +
    +  /**
    +   * Requesting the extra executors other than the existing ones.
    +   *
    +   * @param sc                   sparkContext
    +   * @param requiredExecutors         required number of executors to be 
requested
    +   * @param localityAwareTasks   The number of pending tasks which is 
locality required
    +   * @param hostToLocalTaskCount A map to store hostname with its possible 
task number running on it
    +   * @return
    +   */
    +  final def ensureExecutors(sc: SparkContext,
    --- End diff --
    
    Do not add this function here, add it to DistributionUtil, like in #365. It 
will be reused for spark2 integration


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to