Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/492#discussion_r94772201
--- Diff:
core/src/main/java/org/apache/carbondata/scan/scanner/impl/FilterScanner.java
---
@@ -151,7 +160,13 @@ private void fillScannedResult(BlocksChunkHolder
blocksChunkHolder)
for (int i = bitSet.nextSetBit(0); i >= 0; i = bitSet.nextSetBit(i +
1)) {
indexes[index++] = i;
}
-
+ // loading delete data cache in blockexecutioninfo instance
+ DeleteDeltaCacheLoaderIntf deleteCacheLoader =
+ new BlockletDeleteDeltaCacheLoader(scannedResult.getBlockletId(),
blocksChunkHolder
+ .getDataBlock(),
blockExecutionInfo.getAbsoluteTableIdentifier());
+ deleteCacheLoader.loadDeleteDeltaFileDataToCache();
+ scannedResult
--- End diff --
why we need to set delete delta cache in scan result, i think better to get
the delete delta cache bitset and we can do And of filter scanner bit set here
and set the resulting bit set to scan result so changes will be less and impact
will also reduce
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
