Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/518#discussion_r95505900
  
    --- Diff: 
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
 ---
    @@ -301,4 +304,45 @@ object CommonUtil {
           LOGGER.info(s"mapreduce.input.fileinputformat.split.maxsize: ${ 
newSplitSize.toString }")
         }
       }
    +
    +  def getCsvHeaderColumns(carbonLoadModel: CarbonLoadModel): Array[String] 
= {
    +    val delimiter = if 
(StringUtils.isEmpty(carbonLoadModel.getCsvDelimiter)) {
    --- End diff --
    
    I think delimiter can not be " ", right? so better to use isBlank instead 
of isEmpty


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to