Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/584#discussion_r102623985
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelFilterExecuterImpl.java
---
@@ -343,24 +339,39 @@ private int
readSurrogatesFromColumnGroupBlock(BlocksChunkHolder blockChunkHolde
return 0;
}
- /**
- * Reading the blocks for no dictionary data, in no dictionary case
- * directly the filter data will read, no need to scan the dictionary
- * or read the dictionary value.
- *
- * @param dimensionColumnDataChunk
- * @param index
- * @return
- */
- private String readMemberBasedOnNoDictionaryVal(
- VariableLengthDimensionDataChunk dimensionColumnDataChunk, int
index) {
- return new String(dimensionColumnDataChunk.getChunkData(index),
- Charset.forName(CarbonCommonConstants.DEFAULT_CHARSET));
- }
@Override public BitSet isScanRequired(byte[][] blockMaxValue, byte[][]
blockMinValue) {
BitSet bitSet = new BitSet(1);
bitSet.set(0);
return bitSet;
}
+
+ @Override public void readBlocks(BlocksChunkHolder blockChunkHolder)
throws IOException {
+ for (int i = 0; i < dimColEvaluatorInfoList.size(); i++) {
+ DimColumnResolvedFilterInfo dimColumnEvaluatorInfo =
dimColEvaluatorInfoList.get(i);
+ if (dimColumnEvaluatorInfo.getDimension().getDataType() !=
DataType.ARRAY
+ && dimColumnEvaluatorInfo.getDimension().getDataType() !=
DataType.STRUCT) {
+ if (null ==
blockChunkHolder.getDimensionRawDataChunk()[blocksIndex[i]]) {
+ blockChunkHolder.getDimensionRawDataChunk()[blocksIndex[i]] =
+ blockChunkHolder.getDataBlock()
+ .getDimensionChunk(blockChunkHolder.getFileReader(),
blocksIndex[i]);
+ }
+ } else {
+ GenericQueryType complexType =
complexDimensionInfoMap.get(blocksIndex[i]);
+ complexType.fillRequiredBlockData(blockChunkHolder);
+ }
+ }
+
+ // CHECKSTYLE:OFF Approval No:Approval-V1R2C10_001
--- End diff --
remove this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
