Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/627
  
    Yes, those are the 2 cases we can do binary search on dimension.
    
    Regarding question1 , no it does not create inverted index if the data is 
already sorted(naturally sorted).
    
    Regarding question2, it is an issue pending from long time, it requires 
changes from data writer and as well as data reader to update the sort state.  
    There are attributes like SortState and Encoders in DataChunk of format 
needs to updated properly while writing and get them back while reading to know 
the dimension has inverted_index or not, or it is naturally sorted or not. 
    
    My suggestion is don't change the method of  `setFilterdIndexToBitSet` as 
the old logic is required for no_inverted index and non sorted columns. Update 
the the method `setFilterdIndexToBitSetWithColumnIndex` with your range search. 
 To know the dimension is naturally sorted or not we can add another PR to 
update the read/write logic. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to