Github user ravipesala commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104709184 --- Diff: format/src/main/thrift/carbondata.thrift --- @@ -183,11 +183,23 @@ struct FileFooter{ } /** +* Footer for indexed carbon file +*/ +struct FileFooterVersion3{ + 1: required i64 num_rows; // Total number of rows in this file + 2: required SegmentInfo segment_info; // Segment info (will be same/repeated for all files in this segment) + 3: required list<BlockletIndex> blocklet_index_list; // blocklet index of all blocklets in this file + 4: optional list<BlockletInfo3> blocklet_info_list3; // Information about blocklets of all columns in this file + 5: optional dictionary.ColumnDictionaryChunk dictionary; // blocklet local dictionary +} + +/** * Header for appendable carbon file */ struct FileHeader{ 1: required i32 version; // version used for data compatibility 2: required list<schema.ColumnSchema> table_columns; // Description of columns in this file + 3: required bool is_Footer_Present; // to check whether footer is present or not --- End diff -- Making the field as `required` will loose backward compatability. Better to make as `optional`
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---