Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/635
@QiangCai I have few doubts.
Why primitive data types are supported as no-dictionary columns in this PR?
It supposed to be direct dictionary.
Why date and timestamp are supported in no-dictionary, it already has
direct dictionary support and it much efficient in terms of loading and query.
I think the scope of this PR should be limited to following points.
1. Support Sort_columns in DDL and metadata.
2. Already in old flow all columns with dictionary_include and
dictionary_exclude will become sort_columns and remaining are measures . So now
there would not be any measure concept now so we just make sort_columns should
have sorted and rowid index, and remaining columns should not be sorted/ row
index but it should have value/delta compression if it is number datatype.
I feel it would have been better if we have some discussion in mailing list
before starting the implementation to keep the people sync with you and it
avoids unnecessary rework.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
