Github user mayunSaicmotor commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/638#discussion_r105416528
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -419,6 +419,94 @@ public static int
getFirstIndexUsingBinarySearch(FixedLengthDimensionDataChunk d
return -(low + 1);
}
+ public static int[] getRangeIndexUsingBinarySearch(
--- End diff --
you are right, I really done binary search even for getting the ranges
previously, but yesterday I done performance test and found the performance is
not better than current logic. the binary search range has advantage only under
the condition of data array size is very long and the repeated data is too
much. But usually the data array size is 12000 for a chunk, not too long. So
the binary search range has no advantage and I decide to keep the current logic
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
