Github user ravipesala commented on a diff in the pull request:

    
https://github.com/apache/incubator-carbondata/pull/620#discussion_r106136281
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/newflow/steps/SortProcessorStepImpl.java
 ---
    @@ -74,7 +81,6 @@ public void initialize() throws IOException {
       public Iterator<CarbonRowBatch>[] execute() throws 
CarbonDataLoadingException {
         final Iterator<CarbonRowBatch>[] iterators = child.execute();
         Iterator<CarbonRowBatch>[] sortedIterators = sorter.sort(iterators);
    -    child.close();
    --- End diff --
    
    It is removed as part of refactoring of code to support batch sort. Earlier 
it was needed to get the cardinality of all dimensions. Now there is a new 
interface `DictionaryCardinalityFinder` has been added to figure out the 
cardinalities.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to