Github user QiangCai commented on a diff in the pull request:

    
https://github.com/apache/incubator-carbondata/pull/672#discussion_r107862824
  
    --- Diff: 
integration/hive/src/main/java/org/apache/carbondata/hive/CarbonArrayInspector.java
 ---
    @@ -0,0 +1,191 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.hive;
    +
    +import java.util.ArrayList;
    +import java.util.List;
    +
    +import org.apache.hadoop.hive.serde2.objectinspector.ObjectInspector;
    +import 
org.apache.hadoop.hive.serde2.objectinspector.SettableListObjectInspector;
    +import org.apache.hadoop.io.ArrayWritable;
    +import org.apache.hadoop.io.Writable;
    +
    +/**
    + * The CarbonHiveArrayInspector will inspect an ArrayWritable, considering 
it as an Hive array.
    + * It can also inspect a List if Hive decides to inspect the result of an 
inspection.
    + */
    +public class CarbonArrayInspector implements SettableListObjectInspector {
    +
    +  ObjectInspector arrayElementInspector;
    +
    +  public CarbonArrayInspector(final ObjectInspector arrayElementInspector) 
{
    +    this.arrayElementInspector = arrayElementInspector;
    +  }
    +
    +  @Override
    +  public String getTypeName() {
    +    return "array<" + arrayElementInspector.getTypeName() + ">";
    +  }
    +
    +  @Override
    +  public Category getCategory() {
    +    return Category.LIST;
    +  }
    +
    +  @Override
    +  public ObjectInspector getListElementObjectInspector() {
    +    return arrayElementInspector;
    +  }
    +
    +  @Override
    +  public Object getListElement(final Object data, final int index) {
    +    if (data == null) {
    +      return null;
    +    }
    +
    +    if (data instanceof ArrayWritable) {
    +      final Writable[] listContainer = ((ArrayWritable) data).get();
    +
    +      if (listContainer == null || listContainer.length == 0) {
    +        return null;
    +      }
    +
    +      final Writable subObj = listContainer[0];
    +
    +      if (subObj == null) {
    +        return null;
    +      }
    +
    +      if (index >= 0 && index < ((ArrayWritable) subObj).get().length) {
    +        return ((ArrayWritable) subObj).get()[index];
    +      } else {
    +        return null;
    +      }
    +    }
    +
    +    throw new UnsupportedOperationException("Cannot inspect "
    +      + data.getClass().getCanonicalName());
    +  }
    +
    +  @Override
    +  public int getListLength(final Object data) {
    +    if (data == null) {
    +      return -1;
    +    }
    +
    +    if (data instanceof ArrayWritable) {
    +      final Writable[] listContainer = ((ArrayWritable) data).get();
    +
    +      if (listContainer == null || listContainer.length == 0) {
    +        return -1;
    +      }
    +
    +      final Writable subObj = listContainer[0];
    +
    +      if (subObj == null) {
    +        return 0;
    +      }
    +
    +      return ((ArrayWritable) subObj).get().length;
    +    }
    +
    +    throw new UnsupportedOperationException("Cannot inspect "
    +      + data.getClass().getCanonicalName());
    +  }
    +
    +  @Override
    +  public List<?> getList(final Object data) {
    +    if (data == null) {
    +      return null;
    +    }
    +
    +    if (data instanceof ArrayWritable) {
    +      final Writable[] listContainer = ((ArrayWritable) data).get();
    +
    +      if (listContainer == null || listContainer.length == 0) {
    +        return null;
    +      }
    +
    +      final Writable subObj = listContainer[0];
    +
    +      if (subObj == null) {
    +        return null;
    +      }
    +
    +      final Writable[] array = ((ArrayWritable) subObj).get();
    +      final List<Writable> list = new ArrayList<Writable>();
    +
    +      for (final Writable obj : array) {
    --- End diff --
    
    Better to use Arrays.asList(array)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to