Github user QiangCai commented on a diff in the pull request:

    
https://github.com/apache/incubator-carbondata/pull/722#discussion_r109867805
  
    --- Diff: 
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/sortcolumns/TestSortColumns.scala
 ---
    @@ -154,6 +154,79 @@ class TestSortColumns extends QueryTest with 
BeforeAndAfterAll {
         checkAnswer(sql("select * from sorttable6 where empname = 'madhan'"), 
sql("select * from origintable1 where empname = 'madhan'"))
       }
     
    +  test("no sort_columns with and data loading with heap and safe sort 
config") {
    +    try {
    +      setLoadingProperties("false", "false", "false")
    +      sql("CREATE TABLE sorttable7_heap_safe (empno int, empname String, 
designation String, doj Timestamp, workgroupcategory int, workgroupcategoryname 
String, deptno int, deptname String, projectcode int, projectjoindate 
Timestamp, projectenddate Timestamp,attendance int,utilization int,salary int) 
STORED BY 'org.apache.carbondata.format' tblproperties('sort_columns'='')")
    +      sql(s"""LOAD DATA local inpath '$resourcesPath/data.csv' INTO TABLE 
sorttable7_heap_safe OPTIONS('DELIMITER'= ',', 'QUOTECHAR'= '\"')""")
    +      checkAnswer(sql("select * from sorttable7_heap_safe where empno = 
11"), sql("select * from origintable1 where empno = 11"))
    +      checkAnswer(sql("select * from sorttable7_heap_safe order by 
empno"), sql("select * from origintable1 order by empno"))
    +    } finally {
    +      defaultLoadingProperties
    +    }
    +  }
    +
    +  test("no sort_columns with and data loading with heap and unsafe sort 
config") {
    --- End diff --
    
    fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to