justinmclean commented on code in PR #2193: URL: https://github.com/apache/incubator-celeborn/pull/2193#discussion_r1437999411
########## LICENSE: ########## @@ -210,4 +210,38 @@ for text of these licenses. Apache License 2.0 -------------------------------------- -common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java +Apache Spark +./client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java +./client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DB.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBIterator.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDB.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBProvider.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBIterator.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/StoreVersion.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBBackend.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBProvider.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBIterator.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDB.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBProvider.java + +Apache Kyuubi +./common/src/main/java/org/apache/celeborn/reflect/DynClasses.java +./common/src/main/java/org/apache/celeborn/reflect/DynConstructors.java +./common/src/main/java/org/apache/celeborn/reflect/DynFields.java +./common/src/main/java/org/apache/celeborn/reflect/DynMethods.java +./dev/checkout_pr.sh Review Comment: Listing the files in LICENSE is a good idea so users know where they come from. Is it not a requirement, but anything that makes the licenses easier to check is good by me. If you copied them from Apache Kyuubi, I would use their NOTICE file contents. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
