turboFei commented on code in PR #2891:
URL: https://github.com/apache/celeborn/pull/2891#discussion_r1835166929
##########
common/src/main/scala/org/apache/celeborn/common/protocol/message/ControlMessages.scala:
##########
@@ -1208,11 +1211,16 @@ object ControlMessages extends Logging {
case HEARTBEAT_FROM_APPLICATION_VALUE =>
val pbHeartbeatFromApplication =
PbHeartbeatFromApplication.parseFrom(message.getPayload)
+ val shuffleFallbackCountMap = new util.HashMap[String,
java.lang.Long]()
+ pbHeartbeatFromApplication.getShuffleFallbackCountsMap.asScala.foreach
{ entry =>
+ shuffleFallbackCountMap.put(entry._1, entry._2)
+ }
Review Comment:
can we use the `pbHeartbeatFromApplication.getShuffleFallbackCountsMap`
directly?
or putAll to `shuffleFallbackCountMap`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
