pan3793 commented on code in PR #3043:
URL: https://github.com/apache/celeborn/pull/3043#discussion_r1900433659
##########
common/src/main/java/org/apache/celeborn/common/network/util/NettyUtils.java:
##########
@@ -103,53 +104,59 @@ public static String getRemoteAddress(Channel channel) {
* released by the executor thread rather than the event loop thread. Those
thread-local caches
* actually delay the recycling of buffers, leading to larger memory usage.
*/
- private static PooledByteBufAllocator createPooledByteBufAllocator(
- boolean allowDirectBufs, boolean allowCache, int numCores) {
- if (numCores == 0) {
- numCores = Runtime.getRuntime().availableProcessors();
+ private static ByteBufAllocator createByteBufAllocator(
Review Comment:
update: move the existing comment to the caller side, add new comments to
explain each parameters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
