rmcyang commented on code in PR #3120:
URL: https://github.com/apache/celeborn/pull/3120#discussion_r1972942163
##########
common/src/test/java/org/apache/celeborn/common/network/util/TransportConfSuiteJ.java:
##########
@@ -73,6 +73,11 @@ public void testSsltrustStoreReloadIntervalMs() {
assertEquals(10000, transportConf.sslTrustStoreReloadIntervalMs());
}
+ @Test
+ public void testSslHandshakeTimeoutMs() {
+ assertEquals(10000, transportConf.sslHandshakeTimeoutMs());
Review Comment:
done
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -6084,6 +6091,18 @@ object CelebornConf extends Logging {
.booleanConf
.createWithDefault(false)
+ val SSL_HANDSHAKE_TIMEOUT_MS: ConfigEntry[Long] =
+ buildConf("celeborn.ssl.<module>.sslHandshakeTimeoutMs")
Review Comment:
Yes, this configuration is not going to be only used internally, but will
also used for RPC communication from application to Celeborn Master/Workers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
