RexXiong commented on code in PR #3149:
URL: https://github.com/apache/celeborn/pull/3149#discussion_r1994951793
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -320,6 +324,13 @@ private[celeborn] class Master(
"send-application-meta")
}
+ runTransportMessagesStaticBlockerTask = runTransportMessagesThread.submit(
Review Comment:
Maybe we can use a TransportMessagesHelper to handle pre-register. Besides
this,is pre-register really needed For LifecycleManager/Master/Worker?
##########
client/src/main/java/org/apache/celeborn/client/ShuffleClient.java:
##########
@@ -63,7 +70,16 @@ public static void reset() {
hadoopFs = null;
}
- protected ShuffleClient() {}
+ protected ShuffleClient() {
+ transportMessagesRunner =
+
ThreadUtils.newDaemonSingleThreadExecutor("client-transport-messages-runner");
+ runTransportMessagesStaticBlockerTask =
+ transportMessagesRunner.submit(
Review Comment:
why should register all extensions for every shuffleClient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
