SteNicholas commented on PR #3148: URL: https://github.com/apache/celeborn/pull/3148#issuecomment-2840745079
@Austinfjq, IMO, we could deprecate `celeborn.worker.push.heartbeat.enabled` and `celeborn.worker.fetch.heartbeat.enabled` and introduce `celeborn.<module>.heartbeat.enabled` instead. Meanwhile, it's unnecessary to introduce new config option for closing idle connection, which has `celeborn.worker.closeIdleConnections` and `celeborn.client.closeIdleConnections`. BTW, you should mentition that if `celeborn.push.heartbeat.enabled` or `celeborn.fetch.heartbeat.enabled` is true, `celeborn.data.heartbeat.enabled` should be true in the doc of `celeborn.<module>.heartbeat.enabled` config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
