DDDominik opened a new pull request, #3248:
URL: https://github.com/apache/celeborn/pull/3248
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
add data size limitation to inflight data by introducing a new
configuration: `celeborn.client.push.maxBytesInFlight.perWorker/total` and
defaults to `celeborn.client.push.buffer.max.size *
celeborn.client.push.maxReqsInFlight.perWorker/total`.
for backward compatibility, also add a control:
`celeborn.client.push.maxReqsInFlight.enabled`.
### Why are the changes needed?
celeborn do supports limiting the number of push inflight requests via
`celeborn.client.push.maxReqsInFlight.perWorker/total`. this is a good
constraint to memory usage where most requests do not exceed
`celeborn.client.push.buffer.max.size`. however, in a vectorized shuffle (like
blaze and gluten), a request might be greatly larger then the max buffer size,
leading to too much inflight data and results OOM.
### Does this PR introduce _any_ user-facing change?
Yes, add new config for client
### How was this patch tested?
test on local env
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
