FMX commented on code in PR #3346:
URL: https://github.com/apache/celeborn/pull/3346#discussion_r2168231783
##########
common/src/main/scala/org/apache/celeborn/common/metrics/source/AbstractSource.scala:
##########
@@ -627,6 +627,8 @@ abstract class AbstractSource(conf: CelebornConf, role:
String)
sum
}
+ // Do use this method to get metrics, because it will clear the timeMetrics
queue
+ // Do not use the LogReporter to report metrics
Review Comment:
I have updated the configuration doc and migration guides.
The logger sink is the safety valve for the metrics data. Some users enabled
metrics but do not have metrics collectors. So I think we should enable the
logger sink by default. And there is no side effect to enable logger sink,
`getMetrics` will not remove any gauges or timers, it just removes the outdated
timer outputs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
