SteNicholas commented on code in PR #3358:
URL: https://github.com/apache/celeborn/pull/3358#discussion_r2189834459
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4808,6 +4809,17 @@ object CelebornConf extends Logging {
.timeConf(TimeUnit.MILLISECONDS)
.createWithDefaultString("600s")
+ val CLIENT_READ_NULL_PARTITION_WAIT_TIME: ConfigEntry[Int] =
+ buildConf("celeborn.client.spark.non.partition.wait.time")
+ .categories("client")
+ .version("0.7.0")
+ .doc("The waiting time for Spark client to read the null shuffle
partition on the work side." +
+ "When there are many empty shuffle partitions in the shuffle partition
of a small task," +
+ "the current value can be set small to avoid long waiting times and
the illusion of the" +
+ "task getting stuck")
+ .intConf
Review Comment:
It's better to use `timeConf` instead of `intConf`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
