TheodoreLx opened a new pull request, #3369:
URL: https://github.com/apache/celeborn/pull/3369

   ### What changes were proposed in this pull request?
   
   add code to register gauge to metricRegistry in addGauge method
   
   ### Why are the changes needed?
   
   Because one implementation of addGauge does not register the gauge to the 
metricRegistry, some Sink implementation classes cannot export these gauge 
metrics. For example, you cannot see JVMCPUTime in the metric file printed by 
CsvSink, because CsvSink only prints metrics from the registry variable in 
MetricsSystem.
   ### Does this PR introduce _any_ user-facing change?
   
   no
   
   ### How was this patch tested?
   
   cluster test
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to