mridulm commented on code in PR #3368:
URL: https://github.com/apache/celeborn/pull/3368#discussion_r2210920246
##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportClientFactory.java:
##########
@@ -311,9 +309,11 @@ public void initChannel(SocketChannel ch) {
throw new IOException(String.format("Failed to connect to %s",
address), cf.cause());
}
} else if (!cf.await(connectTimeoutMs)) {
+ cf.channel().close();
throw new CelebornIOException(
String.format("Connecting to %s timed out (%s ms)", address,
connectTimeoutMs));
} else if (cf.cause() != null) {
+ cf.channel().close();
Review Comment:
Catch and ignore `IOException` for both ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
