turboFei commented on code in PR #3403:
URL: https://github.com/apache/celeborn/pull/3403#discussion_r2246168990
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Controller.scala:
##########
@@ -363,6 +363,7 @@ private[deploy] class Controller(
} catch {
case e: IOException =>
logError(s"Commit file for $shuffleKey $uniqueId failed.", e)
+ workerSource.incCounter(WorkerSource.COMMIT_FILES_FAIL_COUNT)
Review Comment:
due it does not throw exception, so the COMMIT_FILES_FAIL_COUNT does not
increase here
https://github.com/apache/celeborn/blob/f3c6f306c18e9fb0e44606017fbe4ed48a997b75/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Controller.scala#L622-L651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
