SteNicholas commented on code in PR #3417:
URL: https://github.com/apache/celeborn/pull/3417#discussion_r2280236052
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StoragePolicy.scala:
##########
@@ -140,7 +140,8 @@ class StoragePolicy(conf: CelebornConf, storageManager:
StorageManager, source:
partitionDataWriterContext.isPartitionSplitEnabled)
partitionDataWriterContext.setWorkingDir(workingDir)
val metaHandler = getPartitionMetaHandler(diskFileInfo)
- if ((storageInfoType == StorageInfo.Type.HDD || storageInfoType
== StorageInfo.Type.SSD) && location.getStorageInfo.localDiskAvailable()) {
+ val diskFull = checkDiskFull(flusher)
+ if ((storageInfoType == StorageInfo.Type.HDD || storageInfoType
== StorageInfo.Type.SSD) && location.getStorageInfo.localDiskAvailable() &&
!diskFull) {
Review Comment:
Could we add this check into `StorageManager#createDiskFile` instead of
before creation of `LocalTierWriter`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
