SteNicholas commented on code in PR #3433:
URL: https://github.com/apache/celeborn/pull/3433#discussion_r2283899497
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/TierWriter.scala:
##########
@@ -668,7 +668,14 @@ class DfsTierWriter(
override def notifyFileCommitted(): Unit =
storageManager.notifyFileInfoCommitted(shuffleKey, filename, dfsFileInfo)
- override def closeResource(): Unit = {}
+ override def closeResource(): Unit = {
+ if (s3MultipartUploadHandler != null) {
+ s3MultipartUploadHandler.close()
Review Comment:
@xy2953396112, no need to call `complete` which waits for flushing data. The
`closeResource` is invoked in `destroy` that only close
`s3MultipartUploadHandler`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
