RexXiong commented on code in PR #3428:
URL: https://github.com/apache/celeborn/pull/3428#discussion_r2286816209
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/AbstractMetaManager.java:
##########
@@ -96,9 +97,16 @@ public abstract class AbstractMetaManager implements
IMetadataHandler {
public final Map<String, Long> shuffleFallbackCounts =
JavaUtils.newConcurrentHashMap();
public final Map<String, Long> applicationFallbackCounts =
JavaUtils.newConcurrentHashMap();
+ public final Map<String, ApplicationInfo> applicationInfos =
JavaUtils.newConcurrentHashMap();
public final ConcurrentHashMap<String, ApplicationMeta> applicationMetas =
JavaUtils.newConcurrentHashMap();
+ public void updateApplicationInfo(
+ String appId, UserIdentifier userIdentifier, Map<String, String>
extraInfo) {
+ applicationInfos.putIfAbsent(
+ appId, new ApplicationInfo(appId, userIdentifier, extraInfo,
System.currentTimeMillis()));
Review Comment:
The registrationTime could be different on each master, but this shouldn't
cause any serious problems.
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/AbstractMetaManager.java:
##########
@@ -96,9 +97,16 @@ public abstract class AbstractMetaManager implements
IMetadataHandler {
public final Map<String, Long> shuffleFallbackCounts =
JavaUtils.newConcurrentHashMap();
public final Map<String, Long> applicationFallbackCounts =
JavaUtils.newConcurrentHashMap();
+ public final Map<String, ApplicationInfo> applicationInfos =
JavaUtils.newConcurrentHashMap();
public final ConcurrentHashMap<String, ApplicationMeta> applicationMetas =
JavaUtils.newConcurrentHashMap();
+ public void updateApplicationInfo(
Review Comment:
Should also support snapshot/restore meta
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
