HolyLow commented on code in PR #3434:
URL: https://github.com/apache/celeborn/pull/3434#discussion_r2292603275
##########
cpp/celeborn/network/tests/MessageTest.cpp:
##########
@@ -153,3 +153,34 @@ TEST(MessageTest, decodeChunkFetchFailure) {
EXPECT_EQ(streamChunkSlice.len, len);
EXPECT_EQ(chunkFetchFailure->errorMsg(), failureMsg);
}
+
+TEST(MessageTest, encodePushData) {
+ const std::string body = "test-body";
+ auto bodyBuffer = memory::ByteBuffer::createWriteOnly(body.size());
+ bodyBuffer->writeFromString(body);
+ const long requestId = 1000;
+ const uint8_t mode = 2;
Review Comment:
It makes no difference as the UT only tests if the corresponding value is
encoded/decoded correctly. The value doesn't have to contain any meaningful
value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
