RexXiong commented on code in PR #3443:
URL: https://github.com/apache/celeborn/pull/3443#discussion_r2300948915
##########
client/src/main/java/org/apache/celeborn/client/read/DfsPartitionReader.java:
##########
@@ -181,15 +181,19 @@ public DfsPartitionReader(
}
}
- private List<Long> getChunkOffsetsFromUnsortedIndex(CelebornConf conf,
PartitionLocation location)
+ private List<Long> getChunkOffsetsFromUnsortedIndex(PartitionLocation
location)
throws IOException {
List<Long> offsets;
- try (FSDataInputStream indexInputStream =
- hadoopFs.open(new
Path(Utils.getIndexFilePath(location.getStorageInfo().getFilePath())))) {
+ String indexPath =
Utils.getIndexFilePath(location.getStorageInfo().getFilePath());
+ try (FSDataInputStream indexInputStream = hadoopFs.open(new
Path(indexPath))) {
+ long indexSize = hadoopFs.getFileStatus(new Path(indexPath)).getLen();
+ byte[] indexBuffer = new byte[(int) indexSize];
+ indexInputStream.readFully(0L, indexBuffer);
+ ByteBuffer buffer = ByteBuffer.wrap(indexBuffer);
+ int offsetSize = buffer.getInt();
offsets = new ArrayList<>();
Review Comment:
Maybe `offsets = new ArrayList<>(offsetSize);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
