SteNicholas commented on code in PR #3455:
URL: https://github.com/apache/celeborn/pull/3455#discussion_r2340422143


##########
common/src/main/java/org/apache/celeborn/common/network/sasl/SecretRegistry.java:
##########
@@ -28,4 +30,9 @@ public interface SecretRegistry {
   void register(String appId, String secret);
 
   void unregister(String appId);
+
+  /** Checks if the SecretRegistry can register the application. */
+  default boolean registrationEnabled() throws IOException {

Review Comment:
   Why does this method throw IOException? IMO, it's unnecessary for method 
which returns boolean value.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to