akpatnam25 commented on code in PR #3491:
URL: https://github.com/apache/celeborn/pull/3491#discussion_r2396019793
##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportClientFactory.java:
##########
@@ -350,19 +352,34 @@ public void operationComplete(final Future<Channel>
handshakeFuture) {
// Execute any client bootstraps synchronously before marking the Client
as successful.
long preBootstrap = System.nanoTime();
logger.debug("Running bootstraps for {} ...", address);
- try {
- for (TransportClientBootstrap clientBootstrap : clientBootstraps) {
+ for (TransportClientBootstrap clientBootstrap : clientBootstraps) {
+ try {
clientBootstrap.doBootstrap(client);
+ } catch (
+ Exception e) { // catch non-RuntimeExceptions too as bootstrap may
be written in Scala
+ long bootstrapTime = System.nanoTime() - preBootstrap;
+ if (clientBootstrap instanceof RegistrationClientBootstrap) {
+ Exception processed =
RegistrationClientBootstrap.processMasterNotLeaderException(e);
+ String message =
+ (processed instanceof MasterNotLeaderException)
+ ? String.format(
+ "Suggested leader is %s",
+ ((MasterNotLeaderException)
processed).getSuggestedLeaderAddress())
+ : e.getMessage();
+ logger.info(
Review Comment:
sure, updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
