SteNicholas opened a new pull request, #3503:
URL: https://github.com/apache/celeborn/pull/3503

   ### What changes were proposed in this pull request?
   
   `jersey-test-framework-core` dependency should exclude `junit5` dependencies 
to execute java test cases for CI.
   
   ### Why are the changes needed?
   
   Modules including `service` don't ececute java test cases in CI at present, 
which caused by `jersey-test-framework-core` dependency including `junit5` 
dependencies. Troubleshooting process is as follows:
   
   ```
   $ mvn clean test -pl service -X
   ...
   [INFO] Using auto detected provider 
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
   [DEBUG] Using the provider 
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
   ...
   ```
   
   `maven-surefire-plugin` uses 
`org.apache.maven.surefire.junitplatform.JUnitPlatformProvider` instead of 
`org.apache.maven.surefire.junit4.JUnit4Provider`, which causes the java test 
cases to not run. The reason why `maven-surefire-plugin` uses 
`org.apache.maven.surefire.junitplatform.JUnitPlatformProvider` is that 
`jersey-test-framework-core` dependency has `junit5` dependencies but the java 
test cases use `junit4`.
   
   ```
   $ mvn dependency:tree -pl service
   ...
   [INFO] +- 
org.glassfish.jersey.test-framework:jersey-test-framework-core:jar:2.39.1:test
   [INFO] |  +- jakarta.xml.bind:jakarta.xml.bind-api:jar:2.3.3:compile
   [INFO] |  +- org.glassfish.jersey.media:jersey-media-jaxb:jar:2.39.1:test
   [INFO] |  +- org.junit.jupiter:junit-jupiter:jar:5.9.1:test
   [INFO] |  |  +- org.junit.jupiter:junit-jupiter-api:jar:5.9.1:test
   [INFO] |  |  |  +- org.opentest4j:opentest4j:jar:1.2.0:test
   [INFO] |  |  |  +- org.junit.platform:junit-platform-commons:jar:1.9.1:test
   [INFO] |  |  |  \- org.apiguardian:apiguardian-api:jar:1.1.2:test
   [INFO] |  |  +- org.junit.jupiter:junit-jupiter-params:jar:5.9.1:test
   [INFO] |  |  \- org.junit.jupiter:junit-jupiter-engine:jar:5.9.1:test
   [INFO] |  |     \- org.junit.platform:junit-platform-engine:jar:1.9.1:test
   ...
   ```
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to