Copilot commented on code in PR #3626:
URL: https://github.com/apache/celeborn/pull/3626#discussion_r2924120500
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/CreditStreamManager.java:
##########
@@ -185,23 +185,21 @@ private void notifyRequiredSegment(
logger.warn("Only non-null SegmentMapPartitionData is expected for
notifyRequiredSegment.");
}
} catch (Throwable e) {
- logger.error(
- String.format("Fail to notify segmentId %s for stream %s.",
requiredSegmentId, streamId),
- e);
+ logger.error("Fail to notify segmentId {} for stream {}.",
requiredSegmentId, streamId, e);
Review Comment:
The log message is grammatically incorrect/unclear (“Fail to …”). Consider
changing it to “Failed to notify …” to improve readability and searchability in
logs.
```suggestion
logger.error("Failed to notify segmentId {} for stream {}.",
requiredSegmentId, streamId, e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
