yew1eb opened a new pull request, #3627:
URL: https://github.com/apache/celeborn/pull/3627
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
Replace three redundant HashMap operations (`containsKey` + `put` + `get`)
with a single `computeIfAbsent` call in `CelebornInputStream#fillBuffer`.
### Why are the changes needed?
`fillBuffer` is on the hot shuffle-read path and called for every batch
read. The original code performs up to three HashMap lookups per batch instead
of one, causing unnecessary CPU overhead at scale.
### Does this PR resolve a correctness bug?
No.
<!-- Yes/No. (Note: If yes, committer will add `correctness` label to
current pull request). -->
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
