akpatnam25 commented on code in PR #3630:
URL: https://github.com/apache/celeborn/pull/3630#discussion_r2957746169
##########
common/src/main/java/org/apache/celeborn/common/network/protocol/EncryptedMessageWithHeader.java:
##########
@@ -137,6 +144,7 @@ public boolean isEndOfInput() throws Exception {
@Override
public void close() throws Exception {
header.release();
+ ReferenceCountUtil.release(body);
Review Comment:
No need, `ByteBuf` extends ReferenceCounted.
```
public static boolean release(Object msg) {
return msg instanceof ReferenceCounted ?
((ReferenceCounted)msg).release() : false;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
