cxzl25 opened a new pull request, #3643:
URL: https://github.com/apache/celeborn/pull/3643

   ### What changes were proposed in this pull request?
   Apply double-checked locking to MemoryManager.initialize() and add 
synchronized to MemoryManager.reset() to make the singleton lifecycle 
thread-safe.
   
   ### Why are the changes needed?
   
   ```java
   26/04/01 10:32:20,050 ERROR [worker 3 starter thread] 
WordCountTestWithAuthentication: create worker failed, detail:
   java.lang.NullPointerException
           at 
org.apache.celeborn.service.deploy.worker.memory.ChannelsLimiter.<init>(ChannelsLimiter.java:52)
           at 
org.apache.celeborn.service.deploy.worker.Worker.<init>(Worker.scala:240)
           at 
org.apache.celeborn.service.deploy.MiniClusterFeature.createWorker(MiniClusterFeature.scala:172)
           at 
org.apache.celeborn.service.deploy.MiniClusterFeature.createWorker$(MiniClusterFeature.scala:153)
           at 
org.apache.celeborn.tests.flink.WordCountTestBase.createWorker(WordCountTest.scala:44)
           at 
org.apache.celeborn.service.deploy.MiniClusterFeature.createWorker(MiniClusterFeature.scala:150)
           at 
org.apache.celeborn.service.deploy.MiniClusterFeature.createWorker$(MiniClusterFeature.scala:149)
           at 
org.apache.celeborn.tests.flink.WordCountTestBase.createWorker(WordCountTest.scala:44)
           at 
org.apache.celeborn.service.deploy.MiniClusterFeature.$anonfun$setUpWorkers$2(MiniClusterFeature.scala:221)
           at 
scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
           at 
org.apache.celeborn.service.deploy.MiniClusterFeature$RunnerWrap.$anonfun$run$1(MiniClusterFeature.scala:50)
           at 
org.apache.celeborn.common.util.Utils$.tryLogNonFatalError(Utils.scala:234)
           at 
org.apache.celeborn.service.deploy.MiniClusterFeature$RunnerWrap.run(MiniClusterFeature.scala:50)
   ```
   
   
   ### Does this PR resolve a correctness bug?
   No
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   GHA
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to