leixm opened a new pull request, #3655:
URL: https://github.com/apache/celeborn/pull/3655

   ### What changes were proposed in this pull request?
   Remove some assertions in the "check if fetch failure task another attempt 
is running or successful" test in SparkUtilsSuite.
   
   
   ### Why are the changes needed?
   
   After CELEBORN-2294 added a zombie TaskSetManager check in 
shouldReportShuffleFetchFailure, the test became flaky due to a race condition. 
The test calls shouldReportShuffleFetchFailure a second time from the test 
thread, but by that point the FetchFailed has already been processed by Spark's 
DAGScheduler — **the TaskSetManager is either marked as zombie** or the task 
has been removed from taskIdToTaskSetManager. This causes the second call to 
return false, failing the assertion.
   
   
   
   ### Does this PR resolve a correctness bug?
   
   No.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   The affected UT: SparkUtilsSuite - check if fetch failure task another 
attempt is running or successful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to