SteNicholas commented on code in PR #3653:
URL: https://github.com/apache/celeborn/pull/3653#discussion_r3056044524
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -1456,8 +1456,10 @@ class PushDataHandler(val workerSource: WorkerSource)
extends BaseMessageHandler
|""".stripMargin)
val diskFileInfo = fileWriter.getDiskFileInfo
if (diskFileInfo != null) {
- if (workerPartitionSplitEnabled && ((diskFull &&
diskFileInfo.getFileLength > partitionSplitMinimumSize) ||
- (isPrimary && diskFileInfo.getFileLength >
fileWriter.getSplitThreshold))) {
+ if (workerPartitionSplitEnabled && diskFull &&
(diskFileInfo.getFileLength >= partitionSplitMinimumSize)) {
Review Comment:
Could you merge if branch for `workerPartitionSplitEnabled` condition as
follows?
```
if (workerPartitionSplitEnabled) {
if (diskFull && diskFileInfo.getFileLength > partitionSplitMinimumSize) {
return StatusCode.HARD_SPLIT
}
if (isPrimary && diskFileInfo.getFileLength >
fileWriter.getSplitThreshold) {
...
}
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
