leixm commented on PR #3652: URL: https://github.com/apache/celeborn/pull/3652#issuecomment-4240954253
> Pretty similar to something I was trying to do with #3593. +1 on getting this in. > > I have one concern here though, it seems like we're making the sorting thread write and flush the response. This can mean that the sorting threads, supposed to purely handle sorting tasks are now assigned a new response serialization and flush responsibilities. > > Should we instead make sure that the response is instead sent by some other set of thread (preferrably the eventloop thread)? We can create a dedicate set of threads for responding to clients perhaps? The sort thread only needs to call `client.getChannel.writeAndFlush(new RpcResponse(xxx))`, which is a very lightweight step. The serialization of the `RpcResponse` object and the flushing at the network layer will be handled by Netty's event loop thread. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
