RexXiong commented on PR #3644: URL: https://github.com/apache/celeborn/pull/3644#issuecomment-4244318686
#3653 has already been merged, which fixes the core issue: when disk is full, returning `HARD_SPLIT` immediately instead of `SOFT_SPLIT` to prevent further writes. The root cause described in #3653 is that `SOFT_SPLIT` mode allows continuous writing even when disk is full, which eventually fills up the reserved space. This PR's approach (real-time space tracking) addresses a different (and likely less critical) problem around heartbeat update latency. Given #3653 already solves the core disk-full issue with a simpler fix, I'm not sure if the complexity introduced by this PR (thread-safety concerns in `setUsableSpace`, exception handling in `acquireBytes`) is still justified. cc @SteNicholas @zaynt4606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
