[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13631051#comment-13631051
 ] 

Hiroaki Kawai commented on CLOUDSTACK-1638:
-------------------------------------------

Can I ask you which part is unsuitable for 4.0.x? I could not get it.
                
> Network plugins won't be notified VM migration.
> -----------------------------------------------
>
>                 Key: CLOUDSTACK-1638
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-1638
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Management Server
>    Affects Versions: 4.0.0, 4.0.1, 4.0.2, 4.1.0, 4.2.0, 4.1.1
>            Reporter: Hiroaki Kawai
>            Assignee: Chiradeep Vittal
>              Labels: patch
>             Fix For: 4.0.2, 4.1.0, 4.2.0
>
>
> The location of the virtual machine is provided by DeployDestination, which 
> will be passed in NetworkGuru#reserve and NetworkElement#prepare.
> During the virtual machine migration, it actually changes DeployDestination 
> and it looks like that it will tell that event to network components as it 
> has NetworkManager#prepareNicForMigration. The problem is that althogh the 
> interface has that method, NetworkManagerImpl does not tell the 
> DeployDestination changes to network components.
> So IMHO, we need to add calls of NetworkGuru#reserve and 
> NetworkElement#prepare in NetworkManagerImpl#prepareNicForMigration . And 
> then, we also need to add calls NetworkGuru#release and 
> NetworkElement#release after the migration, otherwise the network resources 
> that plugin reserved will be kept even when the vm leaves off.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to