[ https://issues.apache.org/jira/browse/CLOUDSTACK-2805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13676883#comment-13676883 ]
ASF subversion and git services commented on CLOUDSTACK-2805: ------------------------------------------------------------- Commit 58b57ca5dbe514c94469a28d2ebaf0474550ecec in branch refs/heads/master from [~sateeshc] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=58b57ca ] CLOUDSTACK-2805 [VMware] addVmwareDc fails with NPE when non-existent DC name is passed to the API Made vcenter as required parameter to addVmwareDc API. Removed stale parameter url from addVmwareDc API. Improved Exception handling, logging remote exception details. > [VMware] addVmwareDc fails with NPE when non-existent DC name is passed to > the API > ---------------------------------------------------------------------------------- > > Key: CLOUDSTACK-2805 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2805 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: VMware > Affects Versions: 4.2.0 > Environment: commit # b4969c4af5264879ccbec01b65b6c94886fc79d4 > Reporter: venkata swamybabu budumuru > Assignee: Sateesh Chodapuneedi > Priority: Minor > Fix For: 4.2.0 > > Attachments: logs.tgz > > > Steps to reproduce : > 1. Have the latest CS setup ready and installed > 2. Try to setup advanced zone with vmware cluster > 3. execute the "addVmwareDc" API with name parameter set to a DC value that > doesn't exist on vCenter. > Observations: > (i) It fails with the following NPE in the mgmt server logs > Here is the api that was executed : > http://10.147.59.194:8096/api?command=addVmwareDc&name=Zone1&zoneId=1&username=administrator&password=password_123&url=http://10.147.60.13/Infra/Cluster1&response=json > snippet from mgmt server log: > 013-06-03 09:03:08,808 DEBUG [cloud.consoleproxy.ConsoleProxyManagerImpl] > (consoleproxy-1:null) Skip capacity scan due to there is no Primary Storage > UPintenance mode > 2013-06-03 09:03:10,655 DEBUG [vmware.resource.VmwareContextFactory] > (ApiServer-4:null) initialize VmwareContext. url: > https://10.147.60.13/sdk/vimService, username: administrator, password: > p*********** > 2013-06-03 09:03:12,304 DEBUG > [network.router.VirtualNetworkApplianceManagerImpl] > (RouterStatusMonitor-1:null) Found 0 routers to update status. > 2013-06-03 09:03:12,307 DEBUG > [network.router.VirtualNetworkApplianceManagerImpl] > (RouterStatusMonitor-1:null) Found 0 networks to update RvR status. > 2013-06-03 09:03:12,411 DEBUG > [network.router.VirtualNetworkApplianceManagerImpl] > (RouterStatusMonitor-1:null) Found 0 routers to update status. > 2013-06-03 09:03:12,414 DEBUG > [network.router.VirtualNetworkApplianceManagerImpl] > (RouterStatusMonitor-1:null) Found 0 networks to update RvR status. > 2013-06-03 09:03:26,955 ERROR [vmware.manager.VmwareManagerImpl] > (ApiServer-4:null) VMware DC discovery failed due to : Exception: > java.lang.NullPointerException > Message: null > 2013-06-03 09:03:26,980 INFO [cloud.api.ApiServer] (ApiServer-4:null) VMware > DC discovery failed due to : Exception: java.lang.NullPointerException > Message: null > 2013-06-03 09:03:26,982 ERROR [cloud.api.ApiServer] (ApiServer-4:null) error! > java.lang.IllegalArgumentException: Line break in reason phrase. > at > org.apache.http.message.BasicHttpResponse.setReasonPhrase(BasicHttpResponse.java:159) > at com.cloud.api.ApiServer.writeResponse(ApiServer.java:887) > at com.cloud.api.ApiServer.handle(ApiServer.java:304) > at > org.apache.http.protocol.HttpService.doService(HttpService.java:375) > at > org.apache.http.protocol.HttpService.handleRequest(HttpService.java:290) > at com.cloud.api.ApiServer$WorkerTask.run(ApiServer.java:988) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1146) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) > at java.lang.Thread.run(Thread.java:679) > (ii) when the same API is executed with correct DC name then everything goes > fine. > http://10.147.59.194:8096/api?command=addVmwareDc&name=Infra&zoneId=1&username=administrator&password=password_123&url=http://10.147.60.13/Infra/Cluster1 > Attaching all the mgmt server logs and db dump to the bug. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira