shweta agarwal created CLOUDSTACK-3156: ------------------------------------------
Summary: needs proper message for failing Add nic command when vmware tools is not installed or not running Key: CLOUDSTACK-3156 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3156 Project: CloudStack Issue Type: Bug Security Level: Public (Anyone can view this level - this is the default.) Components: Network Controller, VMware Affects Versions: 4.2.0 Environment: build: CloudPlatform-4.2-117-rhel6.3.tar.gz Reporter: shweta agarwal Fix For: 4.2.0 Repro steps: 1. Create a VMware zone 2. Create a centos VM on vmware zone 3. Create a network 4. Add this network to the VM Bug: Nic addition failed message is displayed without telling the cause for failure Expectation: Nic addition failed message should be displayed along with proper message of vmware tools is not installed or not running, cannot add nic to vm i-2-37-VM MS log clearly shows Reason for failure 2013-06-24 18:01:53,961 DEBUG [agent.manager.DirectAgentAttache] (DirectAgent-57:null) Seq 5-1643680454: Response Received: 2013-06-24 18:01:53,961 DEBUG [agent.transport.Request] (StatsCollector-3:null) Seq 5-1643680454: Received: { Ans: , MgmtId: 7159676928023, via: 5, Ver: v1, Flags: 10, { GetHostStatsAnswer } } 2013-06-24 18:01:53,968 DEBUG [vmware.resource.VmwareResource] (DirectAgent-138:10.147.40.24) vmware tools is not installed or not running, cannot add nic to vm i-2-37-VM 2013-06-24 18:01:53,976 DEBUG [agent.manager.DirectAgentAttache] (DirectAgent-138:null) Seq 5-1643680455: Response Received: 2013-06-24 18:01:53,976 DEBUG [agent.transport.Request] (DirectAgent-138:null) Seq 5-1643680455: Processing: { Ans: , MgmtId: 7159676928023, via: 5, Ver: v1, Flags: 110, [{"PlugNicAnswer":{"result":false,"details":"Unable to execute PlugNicCommand due to vmware tools is not installed or not running, cannot add nic to vm i-2-37-VM","wait":0}}] } 2013-06-24 18:01:53,977 DEBUG [agent.transport.Request] (Job-Executor-8:job-120) Seq 5-1643680455: Received: { Ans: , MgmtId: 7159676928023, via: 5, Ver: v1, Flags: 110, { PlugNicAnswer } } 2013-06-24 18:01:53,977 WARN [cloud.vm.UserVmManagerImpl] (Job-Executor-8:job-120) Unable to plug nic for VM[User|vmware] due to: due to: Unable to execute PlugNicCommand due to vmware tools is not installed or not running, cannot add nic to vm i-2-37-VM 2013-06-24 18:01:53,985 WARN [cloud.vm.VirtualMachineManagerImpl] (Job-Executor-8:job-120) Failed to plug nic to the vm VM[User|vmware] in network Ntwk[226|Guest|8] 2013-06-24 18:01:53,978 DEBUG [agent.manager.AgentAttache] (DirectAgent-138:null) Seq 5-1643680455: No more commands found 2013-06-24 18:01:54,006 DEBUG [cloud.network.NetworkModelImpl] (Job-Executor-8:job-120) Service SecurityGroup is not supported in the network id=226 2013-06-24 18:01:54,027 DEBUG [cloud.network.NetworkManagerImpl] (Job-Executor-8:job-120) Removed nic id=97 2013-06-24 18:01:54,029 DEBUG [cloud.network.NetworkManagerImpl] (Job-Executor-8:job-120) Revoving nic secondary ip entry ... 2013-06-24 18:01:54,030 ERROR [cloud.async.AsyncJobManagerImpl] (Job-Executor-8:job-120) Unexpected exception while executing org.apache.cloudstack.api.command.user.vm.AddNicToVMCmd com.cloud.utils.exception.CloudRuntimeException: Unable to add NIC to VM[User|vmware] at com.cloud.vm.UserVmManagerImpl.addNicToVirtualMachine(UserVmManagerImpl.java:899) at org.apache.cloudstack.api.command.user.vm.AddNicToVMCmd.execute(AddNicToVMCmd.java:109) at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:155) at com.cloud.async.AsyncJobManagerImpl$1.run(AsyncJobManagerImpl.java:437) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) at java.util.concurrent.FutureTask.run(FutureTask.java:166) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1146) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:679) 2013-06-24 18:01:54,039 DEBUG [cloud.server.StatsCollector] (StatsCollector-3:null) StorageCollector is running... 2013-06-24 18:01:54,054 DEBUG [cloud.async.AsyncJobManagerImpl] (Job-Executor-8:job-120) Complete async job-120, jobStatus: 2, resultCode: 530, result: Error Code: 530 Error text: Unable to add NIC to VM[User|vmware] 2013-06-24 18:01:54,135 DEBUG [agent.transport.Request] (StatsCollector-3:null) Seq 4-1596799493: Received: { Ans: , MgmtId: 7159676928023, via: 4, Ver: v1, Flags: 10, { GetStorageStatsAnswer } } 2013-06-24 18:01:54,199 DEBUG [agent.transport.Request] (StatsCollector-3:null) Seq 7-1141586419: Received: { Ans: , MgmtId: 7159676928023, via: 7, Ver: v1, Flags: 10, { GetStorageStatsAnswer } } 2013-06-24 18:01:54,210 DEBUG [agent.manager.DirectAgentAttache] (DirectAgent-27:null) Seq 1-1872274165: Executing request -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira