[ https://issues.apache.org/jira/browse/CLOUDSTACK-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719545#comment-13719545 ]
ASF subversion and git services commented on CLOUDSTACK-3626: ------------------------------------------------------------- Commit 1744ed7ad5b512135e567576271e11a6e26e4379 in branch refs/heads/ldapplugin from [~chiradeep] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1744ed7 ] CLOUDSTACK-3626 register the correct user and account for api calls made with api keys and secret keys > CallContexts sets all API calls to user=1,account=1 > --------------------------------------------------- > > Key: CLOUDSTACK-3626 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3626 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Reporter: Prasanna Santhanam > Priority: Critical > > Some new code changes in master have been setting the CallContext to user=1, > account=1 for all API calls. Most of them pass because their corresponding > service layer does not really prevent SYSTEM user from executing the API call. > But some of them fail, esp deleteAffinityGroup which explicitly checks for > SYSTEM user and fails the call > Here's a sample of grep -E "Setting CallContext" > vmops.log:2013-07-18 13:00:54,494 DEBUG [cloudstack.context.CallContext] > (RouterMonitor-1:ctx-c3d14bd6) Setting calling context: CallContext[acct=1; > user=1; session=c3d14bd6-a9c2-47ce-82f4-f2898ee0c132] > vmops.log:2013-07-18 13:00:54,499 DEBUG [cloudstack.context.CallContext] > (RouterStatusMonitor-1:ctx-ad79e5a2) Setting calling context: > CallContext[acct=1; user=1; session=ad79e5a2-6af2-4c5a-9840-b6bc93643150] > vmops.log:2013-07-18 13:00:58,805 DEBUG [cloudstack.context.CallContext] > (UserVm-Scavenger-1:ctx-06af21d7) Setting calling context: > CallContext[acct=1; user=1; session=06af21d7-ab23-46bb-b6c0-1678b0e5039d] > vmops.log:2013-07-18 13:01:24,400 DEBUG [cloudstack.context.CallContext] > (RouterStatusMonitor-1:ctx-42a7172b) Setting calling context: > CallContext[acct=1; user=1; session=42a7172b-824d-4e91-a582-68dc32c6d93f] > vmops.log:2013-07-18 13:01:24,496 DEBUG [cloudstack.context.CallContext] > (RouterStatusMonitor-1:ctx-12102029) Setting calling context: > CallContext[acct=1; user=1; session=12102029-2dcf-4afb-b0cb-3040518522f5] > vmops.log:2013-07-18 13:01:54,395 DEBUG [cloudstack.context.CallContext] > (AccountChecker-1:ctx-2481f836) Setting calling context: CallContext[acct=1; > user=1; session=2481f836-8726-47b7-b3e9-6452655c9a41] > mops.log:2013-07-18 13:03:24,497 DEBUG [cloudstack.context.CallContext] > (RouterStatusMonitor-1:ctx-b4656181) Setting calling context: > CallContext[acct=1; user=1; session=b4656181-287f-40b0-bea0-5c63ec351934] > vmops.log:2013-07-18 13:03:54,394 DEBUG [cloudstack.context.CallContext] > (AccountChecker-1:ctx-302b2600) Setting calling context: CallContext[acct=1; > user=1; session=302b2600-17ee-45d4-8de0-30b9316f1904] > vmops.log:2013-07-18 13:03:54,400 DEBUG [cloudstack.context.CallContext] > (RouterStatusMonitor-1:ctx-70a8e43e) Setting calling context: > CallContext[acct=1; user=1; session=70a8e43e-3b0a-4969-a7f3-a71a5742b0ba] > vmops.log:2013-07-18 13:03:54,496 DEBUG [cloudstack.context.CallContext] > (RouterStatusMonitor-1:ctx-2d08465f) Setting calling context: > CallContext[acct=1; user=1; session=2d08465f-ffc4-4a1d-a083-61da87918bd7] > vmops.log:2013-07-18 13:03:58,822 DEBUG [cloudstack.context.CallContext] > (UserVm-Scavenger-1:ctx-57bc3929) Setting calling context: > CallContext[acct=1; user=1; session=57bc3929-c811-4930-a385-db1fa0b01cf8] > vmops.log:2013-07-18 13:04:24,401 DEBUG [cloudstack.context.CallContext] > (RouterStatusMonitor-1:ctx-b0c86d3c) Setting calling context: > CallContext[acct=1; user=1; session=b0c86d3c-3877-44d9-8283-5b52c324f766] > vmops.log:2013-07-18 13:04:24,497 DEBUG [cloudstack.context.CallContext] > (RouterStatusMonitor-1:ctx-854bcdee) Setting calling context: > CallContext[acct=1; user=1; session=854bcdee-3ae9-4791-823d-7f933a266bd0] > vmops.log:2013-07-18 13:04:54,393 DEBUG [cloudstack.context.CallContext] > (AccountChecker-1:ctx-d6bbaeea) Setting calling context: CallContext[acct=1; > user=1; session=d6bbaeea-d106-47cc-a287-5df9eda044be] > vmops.log:2013-07-18 13:04:54,400 DEBUG [cloudstack.context.CallContext] > (RouterStatusMonitor-1:ctx-0d1d3eed) Setting calling context: > CallContext[acct=1; user=1; session=0d1d3eed-9c0f-48f4-a320-a4e1fa8021f8] > vmops.log:2013-07-18 13:04:54,496 DEBUG [cloudstack.context.CallContext] > (RouterStatusMonitor-1:ctx-a57e394c) Setting calling context: > CallContext[acct=1; user=1; session=a57e394c-cb60-47fb-970d-894e24c36d55] > vmops.log:2013-07-18 13:04:58,826 DEBUG [cloudstack.context.CallContext] > (UserVm-Scavenger-1:ctx-885e176f) Setting calling context: > CallContext[acct=1; user=1; session=885e176f-2ba6-4865-8777-591314e7076e] > vmops.log:2013-07-18 13:05:24,401 DEBUG [cloudstack.context.CallContext] > (RouterStatusMonitor-1:ctx-74dc6e45) Setting calling context: > CallContext[acct=1; user=1; session=74dc6e45-cc88-487a-963d-7a91b3807fa3] > vmops.log:2013-07-18 13:05:24,496 DEBUG [cloudstack.context.CallContext] > (RouterStatusMonitor-1:ctx-92ceae00) Setting calling context: > CallContext[acct=1; user=1; session=92ceae00-cfcd-43f1-9130-637e327d7d74] -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira